search

iGBAEmu / EclipseIssues

An issue tracker for Eclipse
https://eclipseemu.me
50 stars 2 forks source link

iPhone X/Xs/11 - Start/Select buttons hard to hit #55

Open JanJastrow opened 4 years ago

JanJastrow commented 4 years ago

Description

I'm using Eclipse as an PWA fullscreen app on my iPhone Xs and I have a lot of problems tapping the "Start" and "Select" buttons while playing. These buttons are at the very bottom of the screen, where on the newer iPhones the "home indicator" is located. This means that iOS thinks you want to tap the "home button" instead of the buttons that are very close to it. I hit the buttons 10-20 times and sometimes I'm able to hit their (very small) remaining hitbox and trigger them.

Can we get a bottom margin of a few pixels for the buttons on iOS PWA?

How to Reproduce

Use the PWA on a modern iOS device

Device Information

iPhone Xs iOS 13.2.3

glennfu commented 4 years ago

I don't have access to the repo (would love to contribute) but it seems like after a quick inspect, this would do the trick:


.emu-controls .start-select button {
    padding-top: 5px;
    padding-bottom: 5px;
}
magnetardev commented 4 years ago

Would you mind testing this out and seeing if it works? This is what we’ll be using in v3, so if it works then that’ll be one common issue off our list. Thanks. (Also we pushed a potential fix a few months ago, but want to tie up all our loose ends!)

https://zenithdevs.github.io/ControllerKit/demo/

JanJastrow commented 4 years ago

Hi, thank you for your answer. I have tried it and it seems to be working very good. No missed clicked as a PWA. :)