search

iGEM-Engineering / iGEM-distribution

Repository for collective design of an iGEM DNA distribution
https://igem-distribution.readthedocs.io
Other
42 stars 20 forks source link

python 3.10 collections test suite update #312

Closed mburridge96 closed 1 year ago

mburridge96 commented 2 years ago

Python 3.10 collections depreciated the use of Iterable. Iterable has now been moved to collections.abc.

Tested in python 3.9 and 3.10 and passed 100% of tests. Python 3.8 had type issues with SBOL.components (ABCMeta type not subscriptable) so could not run helper functions. Question is does the testing suite require python 3.8 support? If it does will have to look into it further

Updated requirements.txt to be more exhaustive of requirements.

Added small troubleshooting section for Ubuntu setup. fix #310

jakebeal commented 1 year ago

@mburridge96 Are these failures expected here?

mburridge96 commented 1 year ago

Not at all, should have failed on testing but not on linting. Will have a look