search

iGEM-Engineering / iGEM-distribution

Repository for collective design of an iGEM DNA distribution
https://igem-distribution.readthedocs.io
Other
42 stars 20 forks source link

Iss313 pylinting #322

Closed GC-repeat closed 1 year ago

GC-repeat commented 1 year ago

Reactivation of the Flake8 and Pylint codes as decided in #313 and fixing the associated errors.

GC-repeat commented 1 year ago

All set but the fixes related to the line too long error in conversion.py and test_import.py should be double checked to make sure what I did makes sense. If we don't want to fix these, the "faulty" lines can be commented to be ignored by the linter. This is what I've done for line 82 of package_specification.py as I wasn't sure how to split the comment. Also, is this comment still relevant given that the related issue has been closed?

jakebeal commented 1 year ago

It all looks correct to me. The line in package_specification.py can stay for now - the patch will be applied when the line gets removed in favor of the package system implementation currently in progress.