[Bug] Non Op/Permission people can run some commands

iGoodie / TwitchSpawn

👾 TwitchSpawn is a Minecraft mod, which is designed for Twitch streamers using 3rd party streaming tools! (comes with its own language!)

https://www.curseforge.com/minecraft/mc-mods/twitchspawn

Eclipse Public License 1.0

52 stars 25 forks source link

[Bug] Non Op/Permission people can run some commands #23

Open Flemmli97 opened 4 years ago

Flemmli97 commented 4 years ago

Describe the bug Non op and permission people can run commands like /twitchspawn test <> and [...] execute, which they shouldnt be able to. ModuleTest and ModuleExecute are missing permission checks

To Reproduce Create server and have non op and non permission people (Credentials.toml) on and let them run the command.

Version (please complete the following information):

TwitchSpawn Version: 0.4.17
Forge Version: 1.12.2-14.23.5.2847

iGoodie commented 4 years ago

Oh I knew I should've created a hook for the permissions check! I always end up forgetting about the permission check.. Thanks once again for revealing another defect!