search

iKenndac / Tofu

An easy-to-use two-factor authentication app for iOS
https://tofuauth.com
ISC License
498 stars 66 forks source link

🆕 Added icons and removed duplicate entry #26

Closed ghost closed 4 years ago

ghost commented 5 years ago

Added entries and icons of:

Removed duplicate FastMail entry.

ghost commented 5 years ago

Hey @Jeremia-h, thanks so much for the PR!

Tofu uses the issuer icon images "as is", without rendering an outline or a background itself. This means that the images have to have these features baked in.

If you have access to Sketch, you can open the IssuerIcons.sketch file and use the template at the top to add outlines and background for your icons.

If not, I can update the images when I get time to do so.

In the future, I hope to also get time to update the issuer icons system to handle transparent images, draw outlines and backgrounds and do automatic downscaling of icons. Hopefully this will make it easier to add new icons.

I've updated it to hopefully meet your guidelines. Please review them and let me know if not.

calleluks commented 4 years ago

Thanks Jeremia! It looks much better!

I think the Firefox icon needs a bit more whitespace around it.

Unfortunately, you seem to have deleted your GitHub account so I don't think you'll see this message. Thanks anyway for your contribution. I'll close this for now and come back to it when I have time to finish it myself.

frozenshadow commented 4 years ago

@calleerlandsson I can edit the Firefox and Paladin icon. However, I'm unable to fork or edit his PR. Do you want me to create a new PR with his changes or do you merge this one (maybe in a new branch) so I can edit?

calleluks commented 4 years ago

Thanks @frozenshadow, that would be great! Unfortunately, I can't reopen this PR because the repo it was submitted from has been deleted.