search

iKenndac / Tofu

An easy-to-use two-factor authentication app for iOS
https://tofuauth.com
ISC License
498 stars 66 forks source link

TOTP with 12 digits causes crash #40

Closed eender closed 3 years ago

eender commented 4 years ago

So I was testing a few 2FA apps and just to mess around I created a QR code with this website: https://freeotp.github.io/qrcode.html

This is just an example: chrome_2020-05-07_18-33-57

!! Don't try to scan this code !!, it will most likely make tofu unusable !

After scanning this with Tofu, the app instantly crashes. And even after deleting and reinstalling the app: I cannot open Tofu! It simply crashes.

I also tried deleting the app, restarting the device and reinstalling the app. No difference.

Tested Tofu Version 1.8 with an iPhone 8 on 13.4.1 Also tried this with an iPhone 6s on 13.4.1

calleluks commented 4 years ago

Thanks for reporting this @eender, and thanks for writing up a fix @benbusby! Let's continue the discussion on #41.

eender commented 3 years ago

I just wanted to give you a quick feedback. Unfortunately, no update has been released so far that solves this problem. That would mean that to this day I can't rely on tofu, because I simply can't open it.

calleluks commented 3 years ago

Sorry about that @eender. I'll look at it whenever I get a chance.

calleluks commented 3 years ago

Hey @eender, I finally got a chance to look at this. Fixed in f43b08dce887226ff2f13dc0eb0b9b8a1bb2770e, 7a94ba60fbc414a7fe4f74810d45ab15e6adda1a, and 1680d09e65962bf8089ec397b52a42efe6a59f43.

I've also pushed a new beta version (1.10 (13)) to TestFlight. Use this link to join the beta program if you want to help test it! https://testflight.apple.com/join/LLe6CFdo

eender commented 3 years ago

Thanks, I can confirm that the newest beta fixed this problem.