Move Icon Creation to GenerateIssuerIconAssets.sh

iKenndac / Tofu

An easy-to-use two-factor authentication app for iOS

https://tofuauth.com

ISC License

491 stars 64 forks source link

Move Icon Creation to GenerateIssuerIconAssets.sh #60

Closed FIGBERT closed 3 years ago

FIGBERT commented 3 years ago

After our discussion on #52, I spent some time implementing the automated icon generation we discussed. The bash script uses sips – which ships with macOS – and ag – an ack alternative that you can install with Homebrew – to generate the icon files.

The one missing feature that we discussed is removing the hard-coded rounded corners, but that can be implemented in another pull request.

calleluks commented 3 years ago

Wow, that's super cool! Thanks so much for working on this! I'll read through the script and post feedback inline.

calleluks commented 3 years ago

I have a branch locally with quite a few icons without rounded corners and code to round them at runtime. Will post a PR with it as soon as I've had time to clean it up somewhat!

FIGBERT commented 3 years ago

Alright, all suggestions implemented. Thanks to @ThinkChaos for the RegEx and directory pointers. Probably should squash before merging.

calleluks commented 3 years ago

Merged as d6b4544f7a996fd2c7a4feaa77cdee7735240749 and 174fcf569a874472365a47e24b050eec0e4a86e9 with some small modifications:

I removed the comment about the regex since it was describing the old one.
I removed some empty lines
I brought back the unoptimized versions of all icons and re-ran the script. Xcode automatically runs all pngs through pngcrush as part of the build. Not optimizing the icons output by the script avoids having to re-optimize them everytime the script is run to avoid binary diffs.

Thanks so much @FIGBERT and @ThinkChaos!