search

iLCSoft / ILDConfig

Package for iLCSoft configuration files related to the ILD detector simulation
GNU General Public License v3.0
3 stars 23 forks source link

Photon energy corrections #106

Closed danieljeans closed 4 years ago

danieljeans commented 4 years ago

BEGINRELEASENOTES

this new config should be used only for ILD_l5_o1_v02 models (and others with the same ECAL structure)

rete commented 4 years ago

TravisCI is failing because the processor is not there yet. We need a nightly build first

rete commented 4 years ago

Hi Daniel. TravisCI seems happy now. :-D However, for the energy correction parameters, my idea of listing the parameters was the following:

Can you write the real parameter values in use their and uncomment all parameters ?

danieljeans commented 4 years ago

Hi Remi,

at the moment the "default corrections" are hardcoded in the photon corrector: you prefer everything to be done via the processor parameters? it would certainly be more flexible...I'll do this and remove the hardcoded default sets.

d.

On 12/11/19 1:50 AM, Ete Remi wrote:

Hi Daniel. TravisCI seems happy now. :-D However, for the energy correction parameters, my idea of listing the parameters was the following:

  • List the real values in use (not -999). This is for documentation and claraification of our config in general
  • If a parameter is listed (not as a comment), anybody can change the value by command line using --Processor.parameter, which makes potential future studies a bit easier.

Can you write the real parameter values in use their and uncomment all parameters ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/iLCSoft/ILDConfig/pull/106?email_source=notifications&email_token=AFTNC3ZXVJV6ZUPW2NFY5OTQX7CGZA5CNFSM4JUSTFWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGP6ANI#issuecomment-564125749, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFTNC36SOION73LJOHP5MQLQX7CGZANCNFSM4JUSTFWA.

-- Daniel JEANS, Institute of Particle and Nuclear Studies (ILC group), KEK, Tsukuba, Japan tel: +81 029-864-5368 PHS: 4880 http://research.kek.jp/people/jeans/