search

iLCSoft / LCIO

Linear Collider I/O
BSD 3-Clause "New" or "Revised" License
17 stars 34 forks source link

delphes2lcio crash #113

Closed danieljeans closed 3 years ago

danieljeans commented 3 years ago

I came across a crash of DelphesSTDHEP2LCIO, due to the use of GetEntriesFast() in l.771 of DelphesLCIOConverter::convertJetCollection

This was an empty jet, for which GetEntries() gave 0 while GetEntriesFast() returned 1 (which lead to an invalid access shortly afterwards.) It's weird to me that they should give different answers...I haven't tried to understand why. Changing to GetEntries() fixed the problem. (I see that the "Fast" version is also used in various other places.)

rete commented 3 years ago

@gaede Is this the recent issue you fixed?

gaede commented 3 years ago

I have fixed it, though I could not reproduce it. Anyways nothing wrong with the fix, I hope...

danieljeans commented 3 years ago

Thanks, I'd forgotten about this. I remember it affected just one event (but don't remember which one...). The fix looks fine.