iLCSoft / LCIO

Linear Collider I/O
BSD 3-Clause "New" or "Revised" License
17 stars 34 forks source link

CMake configuration overhaul #133

Open tmadlener opened 3 years ago

tmadlener commented 3 years ago

The cmake configuration of several ilcsoft packages is pretty old and could potentially profit from exploiting newer cmake functionalities and in general newer cmake paradigms, e.g. target based configurations. Since LCIO is at the very base of everything, it could serve as a good starting point to check what would need changing and could then serve as an example for other packages as well.

A few points that should be decided/considered beforehand:

A more modern cmake configuration has the potential to make some of the cmake macros that are part of ilcsoft obsolete, as cmake can now handle many things for which these macros were originally designed by itself. To which degree we can remove these macros is hard to estimate and will be something we find out along the way.

Other TODOs (keeping them here because then they show up as X of Y in the overview):

tmadlener commented 3 years ago

Arguments for going to cmake > 3.15: https://cmake.org/cmake/help/latest/policy/CMP0094.html#policy:CMP0094

tmadlener commented 3 years ago

https://github.com/iLCSoft/LCIO/pull/132#issuecomment-832071129 for two more points:

tmadlener commented 3 years ago

Some more considerations for the choice of the minimum required cmake version: https://github.com/iLCSoft/LCIO/pull/132#issuecomment-832555662

Romendakil commented 1 year ago

This remark fits to this issue, but feel free to open a separate one: I noticed that the two files LCIOConfig.cmake and LCIOConfigVersion.cmake end up after 'make install' in directly, while for most (maybe all?) cmake built projects I know they are installed/written to /lib/cmake I would find it more consistent for these files to end up of there.

tmadlener commented 1 year ago

Yes, definitely part of this issue. I need to find some time to finalize #140 and then this should also be fixed.

jan-busa commented 8 months ago

When I build latest version v2-20-2, LCIOConfig.cmake is placed under lib/cmake/LCIO/LCIOConfig.cmake and SIOTargets.cmake goes into lib/cmake/SIO/SIOTargets.cmake (notice the different directories). This leads to the problem when LCIOConfig.cmake around line 75 looks for SIOTargets.cmake in the line include("${CMAKE_CURRENT_LIST_DIR}/SIOTargets.cmake"). Of course the easiest way for fix would be to hard-code SIO path as include("${CMAKE_CURRENT_LIST_DIR}/.../SIO//SIOTargets.cmake") but I'm sure, there is a more elegant way, I'm just not so familiar with CMake.

tmadlener commented 8 months ago

I have moved your issue (@jan-busa) into a separate one, because I this one is much broader and more work in general than solving yours (I hope)