iLCSoft / LCIO

Linear Collider I/O
BSD 3-Clause "New" or "Revised" License
17 stars 34 forks source link

Deprecate C-API #137

Closed tmadlener closed 2 years ago

tmadlener commented 3 years ago

BEGINRELEASENOTES

ENDRELEASENOTES

The SimTrackerHitImpl::setCellID function does not exist in cpp, so it probably shouldn't exist for the fortran API either. Also added the non-deprecated lcsthgetcellid0 and lcsthgetcellid1 to the API (implementations were already present).

tmadlener commented 3 years ago

Seems like gcc10 is a bit more stringent than previous versions:

Also there seem to be some additional warnings that are all similar to this one here: https://github.com/iLCSoft/LCIO/runs/2519286851?check_suite_focus=true#step:4:407

However, my limited fortran knowledge is not enough to have an idea of how to fix these.

andresailer commented 2 years ago

Isn't Whizard using the C API?

tmadlener commented 2 years ago

From what we gathered, both Whizard and SGV implement/generate their own Fortran API for LCIO which does not use the C API.

andresailer commented 2 years ago

Ok, thanks for the information!