Adding track nholes to EDM

iLCSoft / LCIO

Linear Collider I/O

BSD 3-Clause "New" or "Revised" License

17 stars 34 forks source link

Adding track nholes to EDM #147

Closed madbaron closed 1 month ago

madbaron commented 2 years ago

BEGINRELEASENOTES

Add Nholes and and subdetectorHoleNumbers to the Track for keeping track of missing hits in a Track.

ENDRELEASENOTES

Inspired by today's discussion at the Joint Tracker and Calorimeter Meeting https://agenda.infn.it/event/31242/, I have added the number of holes to the LCIO track EDM

madbaron commented 2 years ago

Mmh, this was meant to go to the MuonColliderSoft repository (sorry I misclicked in the PR creation). However, this is likely to be useful also upstream, so I leave it here for evaluation.

Cheers, Federico

madbaron commented 1 month ago

@tmadlener I have added the version checks. What else do we need to move forward? Thanks!

madbaron commented 1 month ago

In order to make CI pass again, we have to bump the version manually here:

https://github.com/iLCSoft/LCIO/blob/e8c5032e261708f03514379decd7375038722025/CMakeLists.txt#L14-L16

I would go to 2.22.99 to sort of indicate that this is a "development" version.

done