Closed jmcarcell closed 6 months ago
The tagging script replaces the _VERSION_XYZ lines
Can you instead use PROJECT_VERSION_XYZ?
Mm no that doesn't silence the warning, which is not that much of a problem. I would say the bigger problem is setting the version in a deprecated way:
The OLD behavior for this policy is to leave VERSION variables untouched. The NEW behavior for this policy is to set VERSION as documented by the project() command.
Note
The OLD behavior of a policy is deprecated by definition and may be removed in a future version of CMake.
Options:
project()
.I think since we are already dealing with this we could do 2 in some repos at least since to silence the warning some change is going to be needed anyway
I don't see a real problem with bumping the minimum cmake version to 3.X. X could probably be quite large already such that we at least partially catch up with cmake. (https://github.com/iLCSoft/LCIO/pull/140 would put it to 3.14
)
Actually I don't get the warning anymore (different cmake version? I'm not sure) so we can just leave this PR at a bump on the minimum cmake version which does generate a warning if set too low
BEGINRELEASENOTES
ENDRELEASENOTES
Right now, when running
cmake ..
I get the following warning:The old behaviour of having the variables is deprecated as explained here: https://cmake.org/cmake/help/latest/policy/CMP0048.html so it may be removed in the future but for using the new behavior we need CMake 3.0 (released in 2014).
How
VERSION
works insideproject()
is explained here: https://cmake.org/cmake/help/v3.21/command/project.htmlso that means that this PR will keep the same behavior as before.