iLCSoft / LCIO

Linear Collider I/O
BSD 3-Clause "New" or "Revised" License
17 stars 34 forks source link

Fix possibly wrong behavior with `std::remove_if` #192

Closed jmcarcell closed 2 weeks ago

jmcarcell commented 2 weeks ago

Using std::remove_if alone only does some rearranging and changing elements of _blocks, and that doesn't seem what's intended there. If everyone is using C++20 std::erase_if can be used instead of the erase - remove idiom.

BEGINRELEASENOTES

ENDRELEASENOTES