search

iLCSoft / Marlin

Modular Analysis and Reconstruction for the LINear Collider
GNU General Public License v3.0
11 stars 16 forks source link

StdHepReader.cc not assigning generator status properly #1

Closed scipp-ilcadmin closed 7 years ago

scipp-ilcadmin commented 8 years ago

Hello,

We have discovered that the driver responsible for converting a stdhep file to a collection of MCParticles within Marlin (StdHepReader.cc) is assigning a generator status of 1 (final state) to EVERY particle in the event.

When we analyze the file at the stdhep level (using the StdhepEvent class in the LCSim framework), we see proper generator status assignment. However, after we ran this file through the StdHepReader which converts it to collections of MCParticles, we discovered that each particles had a generator status of 1 (using the getGeneratorStatus() function.)

This flawed driver can be found here: /cvmfs/ilc.desy.de/sw/x86_64_gcc44_sl6/v01-17-09/Marlin/v01-08/source/src/StdHepReader.cc

I wanted to draw attention to this issue and point out that the LCStdHepReader found in the plcio workspace, works great and can be found here: https://stash.desy.de/projects/IL/repos/plcio/browse/source/utilities/LCStdHepReader.cc

Jane Shtalenkova yshtalen@ucsc.edu

gaede commented 7 years ago

I cannot reproduce or understand this problem. The StdHepReader processor does not set the generator status at all but rather uses the LCStdHepReader.cc from LCIO ( which is the original implementation that has been ported to plcio). Can you provide an example stdhep file where this problem occurs ?

petricm commented 7 years ago

No response from issue opener