iLCSoft / Marlin

Modular Analysis and Reconstruction for the LINear Collider
GNU General Public License v3.0
11 stars 16 forks source link

EventSeeder: use vector of pairs to fix order of seeding processors #12

Closed andresailer closed 7 years ago

andresailer commented 7 years ago

The loop over the map is not guaranteed to be constant across time or space so event seeds were not reproducible, because the order of the pointer to the processors depends on the memory.

Now use a vector with fixed order from processors calling to register themselves, which is constant.

BEGINRELEASENOTES

ENDRELEASENOTES

gaede commented 7 years ago

@andresailer would it not have been easier to replace std::map<Processor*, unsigned int> with std::map<std::string, unsigned int> and then use Processor::name() as key ?

andresailer commented 7 years ago

Then you cannot take out processors after the one you are interested in.

gaede commented 7 years ago

Ok, fair enough.