search

iLCSoft / Marlin

Modular Analysis and Reconstruction for the LINear Collider
GNU General Public License v3.0
11 stars 16 forks source link

Make sure that LCIO target is also available downstream #59

Closed tmadlener closed 3 months ago

tmadlener commented 3 months ago

BEGINRELEASENOTES

ENDRELEASENOTES

Otherwise some packages, e.g. KiTrack will not build / link for me.

jmcarcell commented 3 months ago

We can also not use Marlin_LIBRARIES which I would prefer even if it's more work since what's happening now is that some packages are linking a lot of stuff that they don't need, like KiTrack which doesn't need LCIO. See https://github.com/iLCSoft/KiTrack/pull/3 for example. It's three more repositories with a similar change, I can have a look.

tmadlener commented 3 months ago

I agree whit cleaning up the downstream consumers. However, I also think that we still need to properly propagate the fact, that Marlin depends on LCIO. So we need both IMHO.

jmcarcell commented 3 months ago

With the four PRs that appear at the bottom of https://github.com/iLCSoft/Marlin/pull/56 I can build the stack and some missing dependencies are uncovered.

jmcarcell commented 3 months ago

I agree whit cleaning up the downstream consumers. However, I also think that we still need to properly propagate the fact, that Marlin depends on LCIO. So we need both IMHO.

Then I think the target LCIO::lcio shouldn't be created, otherwise cases like KiTrack can't be discovered. And since this is a change being made now I don't think we should worry about older versions of LCIO that would need the LCIO::lcio target.

tmadlener commented 3 months ago

If we don't bootstrap the targets in the MarlinConfig.cmake we have to bump the minimum required version of LCIO that is necessary to build Marlin. Otherwise, this will not be fully transparent.

tmadlener commented 3 months ago

Should we merge this still today (or revert #56) to avoid breaking the nightlies?

jmcarcell commented 3 months ago

Let's merge this today