iLCSoft / MarlinFastJet

Marlin processor to interface FastJet
GNU General Public License v3.0
2 stars 8 forks source link

Adding substructure variables #10

Closed lstroem closed 6 years ago

lstroem commented 6 years ago

BEGINRELEASENOTES

ENDRELEASENOTES

lstroem commented 6 years ago

DONE - Currently adding option to name the output collection from the steering file DONE - Adding also a bool to activate substructure variables or not (default will be false, i.e. nothing new added)

lstroem commented 6 years ago
gaede commented 6 years ago

@lstroem @andresailer Hi, this breaks our nightly builds with:

[ 75%] Building CXX object CMakeFiles/MarlinFastJet.dir/src/FastJetTopTagger.cpp.o
In file included from /scratch/nbuilds/gcc49/2018-05-21/MarlinFastJet/HEAD/src/FastJetTopTagger.cpp:13:0:
/scratch/nbuilds/gcc49/2018-05-21/MarlinFastJet/HEAD/./include/VLCAxes.h:3:45: fatal error: fastjet/contrib/AxesDefinition.hh: No such file or directory
#include <fastjet/contrib/AxesDefinition.hh>

Which version and configuration of fastjet is required for this to work ?

petricm commented 6 years ago

This was tested in the CI with 3.2.1

lstroem commented 6 years ago

Hi Frank,

I was using: /cvmfs/clicdp.cern.ch/software/FastJet/3.2.1/x86_64-slc6-gcc62-opt

from /cvmfs/clicdp.cern.ch/iLCSoft/builds/2017-05-30/x86_64-slc6-gcc62-opt/init_ilcsoft.sh

/Rickard

On 22 May 2018, at 11:09, Frank Gaede notifications@github.com wrote:

@lstroem https://github.com/lstroem @andresailer https://github.com/andresailer Hi, this breaks our nightly builds with:

[ 75%] Building CXX object CMakeFiles/MarlinFastJet.dir/src/FastJetTopTagger.cpp.o In file included from /scratch/nbuilds/gcc49/2018-05-21/MarlinFastJet/HEAD/src/FastJetTopTagger.cpp:13:0: /scratch/nbuilds/gcc49/2018-05-21/MarlinFastJet/HEAD/./include/VLCAxes.h:3:45: fatal error: fastjet/contrib/AxesDefinition.hh: No such file or directory

include <fastjet/contrib/AxesDefinition.hh>

Which version and configuration of fastjet is required for this to work ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/iLCSoft/MarlinFastJet/pull/10#issuecomment-390919139, or mute the thread https://github.com/notifications/unsubscribe-auth/AUr0FOQB5iblhzAHTS4Rxhh1-D7pOAyVks5t09XlgaJpZM4TytQ5.

petricm commented 6 years ago

As this is a contrib thing, did you build FastJetContrib with Nsubjettiness?

gaede commented 6 years ago

I don't know - we built it with the standard ilcsoft install script and:

ilcsoft.install( FastJet( FastJet_version ))
ilcsoft.module("FastJet").fjcontrib_version="1.017"

Which script did you use to build it ?

petricm commented 6 years ago

I think contrib 1.017 is too old (released 2015-05-05), and approx 3 year ago this was added to Nsubjettiness

https://fastjet.hepforge.org/trac/browser/contrib/contribs/Nsubjettiness/trunk

Why are you mixing fastjet 3.2.0 (released 2016-03-17) with fastjet-contrib 1.017(released 2015-05-05)? Did you maybe forget to bump the contrib version when updating the fastjet version? As 3.2.0 would go with 1.022 (which has AxesDefinition.hh).

We don't use iLCSoft to install external packages, they are provided independently.

gaede commented 6 years ago

Indeed, this is a bug in our script - in the versions file we have:

FastJet_version = "3.2.0"
FastJetcontrib_version = "1.024"

but then ignore the contrib version...
I can't find 'valid' combinations of FastJet and contrib versions on their website - which contrib versions did you use for your installations of FastJet (3.2.1, 3.2.2 and 3.3.0 ) ?

petricm commented 6 years ago

Indeed there is no "valid" pairing of the two, the releases are usually "quite" together

3.2.0 17 March 2016 1.022 30 March 2016

but then patches are fairly random. We use 3.2.1+1.025 since the release is from 11/2016.

gaede commented 6 years ago

Ok, thanks. Will then also use 3.2.1+1.025, to be compatible (and rely on the testing you've already done with this).