Fix leaking output collections

iLCSoft / MarlinFastJet

Marlin processor to interface FastJet

GNU General Public License v3.0

2 stars 8 forks source link

Fix leaking output collections #22

Closed Zehvogel closed 2 years ago

Zehvogel commented 2 years ago

I ran into some issues with my naf jobs being halted for using too much memory and traced it to the output collections that are never cleaned up.

BEGINRELEASENOTES

FastJetProcessor: Fix memory leak caused by missing cleanup of output collections.

ENDRELEASENOTES

andresailer commented 2 years ago

Under what circumstances were the collections not added to the evt and thus not cleaned?

Zehvogel commented 2 years ago

Under what circumstances were the collections not added to the evt and thus not cleaned?

Can you point me to the code where this cleanup is happening? I was not aware that this should be the case. For me memory usage of this processor decreased strongly with these changes.

Zehvogel commented 2 years ago

Sorry, taking a second look now, I am confused myself how my changes would be helpful :/ I am puzzled were the improvement I saw came from, clearly something else must have went wrong...