search

iLCSoft / MarlinFastJet

Marlin processor to interface FastJet
GNU General Public License v3.0
2 stars 8 forks source link

Add support for default value of Inclusive minPt parameter, if not se… #9

Closed lstroem closed 7 years ago

lstroem commented 7 years ago

BEGINRELEASENOTES

ENDRELEASENOTES

lstroem commented 7 years ago

André: I added a message saying that the default value is used if minPt is not configured. Frank: If that is what is preferred we should at least catch the error, right now it gives me the output pasted below:

A runtime error occured - (uncaught exception): lcio::Exception: Wrong Parameter(s) for Clustering Mode. Expected: \<parameter name="clusteringMode" type="StringVec"> Inclusive \<minPt> \</parameter>" Marlin will have to be terminated, sorry.

Or maybe this "uncaught exception" is normal?

gaede commented 7 years ago

@lstroem in principle this uncaught exception is the right thing, as the steering file is incomplete/incorrect. To make it yet more clear to the users you could add a printout right before throwing the exception, e.g.:

streamlog_out(ERROR)  << "Wrong numbers values for parameter clusteringMode "Inclusive" : missing minPt" << std::endl

this way the user immediately knows which processor to update. Note this is done for other parameters in this code.

lstroem commented 7 years ago

ok, thanks for the comments! New version pushed to fork feature branch. I've implemented the new comment suggested instead of the default stuff. Indeed it is more clear than before, since this error shows up in the bottom of the output log file instead of hidden in the bulk text somewhere.