iLCSoft / MarlinReco

GNU General Public License v3.0
4 stars 40 forks source link

Fix warnings that are trivial to fix #101

Closed tmadlener closed 3 years ago

tmadlener commented 3 years ago

BEGINRELEASENOTES

Thanks to Bohdan Dudar (@dudarboh)

ENDRELEASENOTES

Split the "trival" fixes from #99 for easier reviewing

Status (via make 2>&1 | sed -nr 's/.+ \[-(.*)\].*/\1/p' | sort | uniq -c) before (against v02-02-02 release):

     38 Wcatch-value=
      2 Wdangling-else
     21 Wdeprecated-declarations
    186 Weffc++
      6 Wignored-qualifiers
      1 Wint-in-bool-context
     64 Wshadow
      3 Wsign-compare
      1 Wsizeof-pointer-div
     33 Wunused-but-set-variable
      2 Wunused-function
     26 Wunused-parameter
      3 Wunused-variable
      2 Wvla

Status now:

      2 Wdangling-else
     21 Wdeprecated-declarations
      6 Weffc++
      1 Wint-in-bool-context
     55 Wshadow
      1 Wsizeof-pointer-div
     34 Wunused-but-set-variable
      2 Wunused-function
     23 Wunused-parameter
      6 Wunused-variable
      2 Wvla