search

iLCSoft / SIO

Simple IO package
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

Migrate to github actions for CI #16

Closed tmadlener closed 3 years ago

tmadlener commented 3 years ago

BEGINRELEASENOTES

ENDRELEASENOTES

Does github actions have something like coverity scan? I think apart from that this should be pretty much equivalent to what was done before.

rete commented 3 years ago

@andresailer Github actions are not triggered in this PR. I looked in the repository settings and couldn't find where to add github actions to the required statuses to pass for PRs. Any idea?

rete commented 3 years ago

@andresailer @tmadlener No way to trigger github actions. Can it be possible that we have to merge this before it triggers Github actions?

tmadlener commented 3 years ago

I am actually not sure. The github actions seem to run succesfully though: https://github.com/tmadlener/SIO/actions/runs/480911173

So at least this shouldn't break anything.

andresailer commented 3 years ago
  1. action not running: https://github.com/tmadlener/SIO/actions doesn't list anything about the "pull_request" event having triggered anything. So maybe because of that there is no status here. Maybe the close/open triggers the pull request status. On this repo (not Thomas' fork) it will only run once merged
  2. Required: this setting is under branch, but you can only select checks that recently ran
  3. coverity: hasn't really worked in some time :( of course the running and pushing should also be possible via github action (maybe there is one somewhere already)
rete commented 3 years ago

I suggest we try to merge this and see. @tmadlener After the merge, wait a bit before rebasing the other PR.