default compression level: Z_DEFAULT_COMPRESSION (-1)

iLCSoft / SIO

Simple IO package

BSD 3-Clause "New" or "Revised" License

0 stars 9 forks source link

default compression level: Z_DEFAULT_COMPRESSION (-1) #4

Closed gaede closed 4 years ago

gaede commented 4 years ago

BEGINRELEASENOTES

set the default compression level to Z_DEFAULT_COMPRESSION (-1)
- correct the documentation for set_level()

ENDRELEASENOTES

rete commented 4 years ago

TravisCI does not seem happy. Can you investigate please?

gaede commented 4 years ago

Beats me - it works on my mac with llvm and the class zlib_compression is not used at all in the relocation_read test. Could this be a problem of the CI configuration for llvm ?

rete commented 4 years ago

Ok, looks like we have a more general problem indeed. The CI is failing for any PR (also #5 and #3 ). I will investigate

rete commented 4 years ago

Beats me too... I tried different debug statements in the test code and found that adding this printout makes the test passing:

https://github.com/iLCSoft/SIO/pull/6/commits/742586c7065a8884b422450cf5af534a986bed5e#diff-4d6d06f2e0ef2a3891e972897e450f76R46

Weird...

rete commented 4 years ago

@gaede The travis issue has been fixed in #8 . Can you rebase please?