search

iLCSoft / iLCInstall

Python scripts to install iLCSoft software and dependencies
GNU General Public License v3.0
4 stars 26 forks source link

Update scripts to python3 #132

Closed tmadlener closed 2 years ago

tmadlener commented 3 years ago

Some (most) of the scripts that automate parts of the release process are not python3 compatible. Parts could potentially be handled by 2to3 but I am afraid that still some more manual changes are necessary.

The question is: Do we need compatibility with both or can we drop python2 compatibility in the process?

tmadlener commented 3 years ago

Re-using this to keep track of other smaller things that should be addressed in the process:

tmadlener commented 3 years ago
andresailer commented 3 years ago

a) ignore all but ... you mean just take the block from the opening post of the PR, and not the comments, right? this was initially intentional, but with admins ability to edit the opening post this isn't needed b) missing cmakelists: What would you like to happen? Error message and exit, warning and continue, something else?

tmadlener commented 3 years ago

a) ignore all but ... you mean just take the block from the opening post of the PR, and not the comments, right?

Yes, exactly. Mainly, because it happened for the current release that it also picked up comments, that were just saying to put them into the opening post of the PR. E.g.: https://github.com/iLCSoft/MarlinReco/pull/85#issuecomment-765328575

b) missing cmakelists: What would you like to happen? Error message and exit, warning and continue, something else?

Also, this is mainly just a convenience thing, because it would then be possible to easily tag iLCInstall itself with the script. Currently that fails before the tag is made, because it can't find a CMakeLists.txt. Maybe leaving the default behavior as is, but having an additional command line flag to ignore the CMakeLists.txt is the best, so that you have to consciously make the choice.

tmadlener commented 2 years ago

I think after #143 all scripts should now be working with python3 as well.