Py3 tagger - Githubissues

iLCSoft / iLCInstall

Python scripts to install iLCSoft software and dependencies

GNU General Public License v3.0

4 stars 26 forks source link

Py3 tagger #139

Closed andresailer closed 3 years ago

andresailer commented 3 years ago

I think this works. cf. https://github.com/iLCSoft/CLICPerformance/releases/tag/v02-04-01

Related to #132

BEGINRELEASENOTES

ilcsofttagger: make python3 compatible, keep python2 compatibility for the moment
ilcsofttagger: add --ignoreMissingCmake flag to ignore the absence of CMakeLists.txt in the repository
ilcsofttagger: no longer look up release notes in comments to PRs, only the opening post
ilcsofttagger: try to get author name from the first commit of a PR not the last, might fix issue with wrongly attributed changes in the release notes

ENDRELEASENOTES

andresailer commented 3 years ago

Thanks for checking! Shame on me, I tested with PYTHONPATH=$PWD/tagging:$PYTHONPATH that hides the import issues

I agree with the ignoring of the non-conforming version strings, better than adding special exceptions for these cases.

andresailer commented 3 years ago

@tmadlener Please have another go at it.

tmadlener commented 3 years ago

Did a few dry-runs with python2 and python3. Everything seems to work now in both versions. Thanks :)

I suppose a similar exercise will be necessary for the install script? Or has that already been ported? It is in any case not really urgent, since our current release is still running with python2, so I will also use that to make the installation.

andresailer commented 3 years ago

I think I implemented all your suggestions and wishes