Make version parsing work for ILDConfig tags

iLCSoft / iLCInstall

Python scripts to install iLCSoft software and dependencies

GNU General Public License v3.0

4 stars 26 forks source link

Make version parsing work for ILDConfig tags #146

Open tmadlener opened 3 years ago

tmadlener commented 3 years ago

A few tags in ILDConfig have an ever so slightly different format, using p instead of pre, which breaks the tagging script.

BEGINRELEASENOTES

Make the tagging script no longer error for ILDConfig patch releases with a pXY patch version specifier. NOTE: This only makes the tagging script ignore such tags. It does not handle them on the same footing as other versions.

ENDRELEASENOTES

andresailer commented 3 years ago

Those ILDConfig tags with a p aren't pre-releases though, are they?

tmadlener commented 3 years ago

Those ILDConfig tags with a p aren't pre-releases though, are they?

Good question, @gaede should they be considered rather as patch releases to the config with a dedicated naming scheme that does not conflict with the usual ilcsoft versioning scheme?

gaede commented 3 years ago

Yes, Andres is right - only tags containing 'pre' are pre-releases. We often use sth. like -p01 as patch releases. The rationale is that the first part of the ILDConfig version should be that of the ilcsoft release that it is compatible with. (So no p01 or the like in ilcsoft versions - only ILDConfig...)

tmadlener commented 2 years ago

triggering CI