search

iLLeniumStudios / illenium-appearance

fivem-appearance for qb-core and ESX framework, packed with a lot of features
MIT License
248 stars 222 forks source link

refactor: ace permissions #389

Closed Manason closed 8 months ago

Manason commented 8 months ago

Rather than use console prints of all possible ace permissions, introducing a config option for the user to specify all the ace permissions to check against. This supports dynamic permission assignment using ox_lib ACL, as the ace permission may not be assigned to any players on server start.

An even better follow-up step from this PR might be to pull the list of ace permissions to check against from the various blacklist configs rather than duplicate the list in a different part of config. But this is a simpler stop-gap solution than current main

TheiLLeniumStudios commented 8 months ago

Makes sense. What I did was overkill and unnecessary.

I'll merge the PR. Feel free to add in the improvement that you mentioned which is gonna fetch all the used aces from the blacklist config in a followup PR if you can. Otherwise I'll see if I can add it when I have time.

Thanks again for the contribution