search

iLexDev / ASP.NET-WebApi-MultipartDataMediaFormatter

Used for binding custom types (including files) when sending and receiving multipart encoded form data
MIT License
93 stars 44 forks source link

Is this still active? #13

Closed cristianocca closed 7 years ago

cristianocca commented 8 years ago

Hi there, is this still active? Just wondering if an external library like this is still needed for Web Api 2, since I couldn't find anything similar.

iLexDev commented 8 years ago

Hello! Yes, it is steel useful for Web Api 2. As far as I remember such custom solutions is obsolete only for new asp.net core.

2016-10-06 0:53 GMT+03:00 Cristiano Coelho notifications@github.com:

Hi there, is this still active? Just wondering if an external library like this is still needed for Web Api 2, since I couldn't find anything similar.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/iLexDev/ASP.NET-WebApi-MultipartDataMediaFormatter/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/AFPf-sKpzJR7SBzFeBqGxLCfMZ-aOQDZks5qxBxUgaJpZM4KPVI4 .

cristianocca commented 8 years ago

Hi, I have tried it and it works like a charm, I can't believe something like this isn't supported natively. I'm wondering if you are still maintaining this.

I would like to know and/or even do it myself as a pull request, if it is possible to change the actual data type used to store the file contents ( right now a byte[]) to something like a spooled file that will either save to a memory stream or a disk temporary file if it gets too large, since a byte[] seems like it could blow up in any time with large files.

iLexDev commented 8 years ago

Hi, thank you for the suggestion.

From the beginning this formatter was not designed to handle uploading really large files and I didn't investigate all issues related to this topic in asp.net web api.

The easiest solution would be to add another file model type with stream inside instead of byte[]. Maybe this stream should be a reference to HttpStream from HttpContent, I am not fully sure about this.

It should be well investigated and covered by tests and I am not sure if I find enough time to do this in a nearest future.

2016-10-07 6:03 GMT+03:00 Cristiano Coelho notifications@github.com:

Hi, I have tried it and it works like a charm, I can't believe something like this isn't supported natively. I'm wondering if you are still maintaining this.

I would like to know and/or even do it myself as a pull request, if it is possible to change the actual data type used to store the file contents ( right now a byte[]) to something like a spooled file that will either save to a memory stream or a disk temporary file if it gets too large, since a byte[] seems like it could blow up in any time with large files.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iLexDev/ASP.NET-WebApi-MultipartDataMediaFormatter/issues/13#issuecomment-252142586, or mute the thread https://github.com/notifications/unsubscribe-auth/AFPf-nFkP5lDs1ZkVi0xzZ02JeLQ_rJ7ks5qxbZngaJpZM4KPVI4 .