search

iLexiconn / LLibrary

The lightweight Minecraft modding library.
https://github.com/iLexiconn/LLibrary/wiki
GNU Lesser General Public License v2.1
52 stars 31 forks source link

LLibrary causing cascading lag on worldgen #79

Open duhadventure opened 6 years ago

duhadventure commented 6 years ago

image LLibrary is causing cascading lag for the server and clients.

Gegy commented 6 years ago

LLibrary doesn't do any worldgen... What other mods do you have installed?

duhadventure commented 6 years ago

https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/2361125-mowzies-mobs-fantasy-mobs-for-your-mc-world

Gegy commented 6 years ago

@BobMowzie any ideas on this? Could your mod be causing generation while in the LLibrary context?

BobMowzie commented 6 years ago

All worldgen in Mowzie's Mobs is called through this class: https://github.com/BobMowzie/MowziesMobs/blob/1.12/src/main/java/com/bobmowzie/mowziesmobs/server/world/MowzieWorldGenerator.java

I use the structure builder for the structures themselves, but I can't imagine that's an issue. What exactly is "cascading" worldgen lag?

pau101 commented 6 years ago

@BobMowzie Cascading generation refers to the generation of a chunk causing another to generate, typically caused by setting or getting blocks in neighboring chunks.

Gegy commented 6 years ago

LLibrary never calls getBlockState, and only calls setBlockState from the StructureBuilder... huh

Gegy commented 6 years ago

Alright. Think I've found the issue: the syncing BlockEntity class sends update packets to all players, forcing them to load the chunk that the TE is in. Only weird thing is that shouldn't happen during chunk generation, so shouldn't cause that message.

EDIT: Nevermind that, Mowzie's Mobs doesn't have any classes extending BlockEntity.

Gegy commented 6 years ago

@duhadventure Is that the only other mod you have installed?

plausibleusername commented 6 years ago

I just got this issue too. Froze my game for ten seconds, and when it unfroze I had been murdered by an angry zombie. But I've got a laundry list of miscellaneous mods, from Thaumcraft to PrimitiveMobs (and Mowzie's Mobs, too, which is the reason I have LLibrary to begin with), so I'm not strictly sure that nothing's interfering.

stardok4 commented 3 years ago

Know this is an old issue, but I am also having it, and yeah I also have a decent amount of mods installed

BobMowzie commented 3 years ago

Oh, it’s possible that my structure generation was leaking into ungenerated chunks. You’ll have to disable Barako and the Wroughtnaut in the mod config to make this stop. Though I’ve never experienced any issues around it while playing.