search

iLexiconn / Magister.java

A Java implementation of the Magister 6 API for desktop and Android.
MIT License
6 stars 3 forks source link

Added User object to get rid of the hashmap.put methods #40

Closed KeizerDev closed 8 years ago

iLexiconn commented 8 years ago

Please fix the variable names first

KeizerDev commented 8 years ago

@iLexiconn Yeah, sorry :wink:

KeizerDev commented 8 years ago

Just copy and pasted it from another project.

KeizerDev commented 8 years ago

Btw, i'll change it to a serialized object.

KeizerDev commented 8 years ago

You can revert it.

iLexiconn commented 8 years ago

Too late. :/

KeizerDev commented 8 years ago

There is the Revert button for :p

iLexiconn commented 8 years ago

I know, but I already made changes to the class.

KeizerDev commented 8 years ago

Already fixed it tho

iLexiconn commented 8 years ago

Make a new pr for it. :p

KeizerDev commented 8 years ago

Lol, you did it already ;p.

Btw. Why do you keep the getters for password, username and stayLoggedIn?
user.password, etc. will actually do the same.

iLexiconn commented 8 years ago

Because they're private, and I want other classes to be able to access them.

iLexiconn commented 8 years ago

Well, maybe we shouldn't save the password as a variable at all.

KeizerDev commented 8 years ago

Just do it. I want it :D

iLexiconn commented 8 years ago

Why do you need it?

KeizerDev commented 8 years ago

Testing purposes

KeizerDev commented 8 years ago

Lol, joking. You can make a test if people are not changing their password in their current password for example.

iLexiconn commented 8 years ago

Pretty sure magister returns an error if that's the case.

KeizerDev commented 8 years ago

True, but data is data and as a library for mainly devices you should try to minimize it as most as possible.

KeizerDev commented 8 years ago

And what if people are losing their session? Do you want them to relog or just get the one you can store? I'm pretty sure every Android app that is build for Magister stores that kind of stuff

iLexiconn commented 8 years ago

I really hope you aren't getting all those passwords from your Mister app.

KeizerDev commented 8 years ago

Not anymore. Got like 70 with it just to keep on with development when I left school.

KeizerDev commented 8 years ago

The rest of the list was from other sources

KeizerDev commented 8 years ago

But that's not my point.

iLexiconn commented 8 years ago

I really don't think this is acceptable. I'm not going to story the password in any kind of way.

KeizerDev commented 8 years ago

Lol, I hope you know that you firstly won't store them and secondly, there are like 1000 ways to still get them. But yeah, it is your library so you can choose

KeizerDev commented 8 years ago

And what I mean with store is locally.