search

iLib-js / iLib

A library of i18n routines written in Javascript.
Apache License 2.0
36 stars 4 forks source link

Merge to master to publish v14.17.0 #421

Closed ehoogerbeets closed 1 year ago

ehoogerbeets commented 1 year ago

Checklist

Issue Resolved / Feature Added

Resolution

Links

ehoogerbeets commented 1 year ago

This should be retested on QT before we merge.

gouniLee commented 1 year ago

ah... there's one test fail case in both qt and browser too. (I missed this case before) It's a newly activated case regarding calendar conversion. https://github.com/iLib-js/iLib/blob/development/js/test/date/testdatefmt_es_CO.js#L275 It expects "2011-10-11". maybe due to my timezone...?

gouniLee commented 1 year ago

and the option is a typo. should be calendar not lendar https://github.com/iLib-js/iLib/blob/development/js/test/date/testdatefmt_es_CO.js#L263

after I fixed it, the expected result become different as '2011-09-29' (node) and '2011-09-28'(browser/qt)

gouniLee commented 1 year ago

All of the tests are passed on Qt v6.4.0 and v6.2.2 and chrome browser v102 (102.0.5005.115) and v109 (109.0.5414.119)