inline styles should be replaced by css styles

Sophist-UK commented 7 years ago

Many of the abbc3 default bbcodes have inline css. For example the [mod] bbcode consists of the following:

<table class="ModTable" style="background-color:#FFFFFF;border:1px solid #000000;border-collapse:separate;border-spacing:5px;margin:1em 0;padding:0;width:100%;color:#333333;overflow:hidden;">
<tr>
<td class="exclamation" rowspan="2" style="background-color:#ff6060;font-weight:bold;font-family:'Times New Roman',Verdana,sans-serif;font-size:4em;color:#ffffff;vertical-align:middle;text-align:center;width:1%;">&nbsp;!&nbsp;</td>
<td class="rowuser" style="border-bottom:1px solid #000000;font-weight:bold;">{L_MESSAGE} {L_FROM}{L_COLON} {IDENTIFIER}</td>
</tr>
<tr><td class="rowtext">{TEXT}</td></tr>
</table>

I suggest that all the style attributes be moved to css and a class attribute be used to call the css.

iMattPro commented 7 years ago

They are inline so they can be customized by the admin editing the BBCode to taste. And, the idea is for most of the BBCodes to be self contained and not rely on this extension to be installed.

Sophist-UK commented 7 years ago

Fair enough.

iMattPro / abbc3

inline styles should be replaced by css styles #40