search

iMerica / dj-rest-auth

Authentication for Django Rest Framework
https://dj-rest-auth.readthedocs.io/en/latest/index.html
MIT License
1.65k stars 306 forks source link

question: logging in a user through dj-rest-auth via django-allauth perform_login vs django_login #31

Open fessacchiotto opened 4 years ago

fessacchiotto commented 4 years ago

hi! while attempting to use the user_logged_in signal from allauth, since it did not fire, i had to look at the source code and i found that in LoginView the django-allauth login function is not used rather it is used the django_login one. thus i connected my receiver to the django signal and all was fine. just for information, what has been the thinking about this decision (django login vs allauth)? cheers!

iMerica commented 4 years ago

This was a decision made by the original creators of Django Rest Auth. As a user this is fine with me because I need any login signal - I don't care if its Django's or All-Auth's.

Do you think we should add a note to the FAQ about it? https://dj-rest-auth.readthedocs.io/en/latest/faq.html

fessacchiotto commented 4 years ago

Do you think we should add a note to the FAQ about it?

Hello! I think we should probably enhance the section of the documentation regarding the signals that the user can connect to. For example, at least from what library package he has to import a given signal, and list all signals available to a user to use in his code.

jeafreezy commented 2 years ago

This thread was helpful. Thanks for raising this @fessacchiotto