Closed kiraware closed 1 year ago
It's Ready for Review!!!
@iMerica and Anyone please review this PR :) Your suggestions matter!!!
Thanks for submitting this pull request! Give me a day or two to review it please.
My pleasure sir!
I think the reload_api_settings
logic adds unnecessary scope to the goal of this pull request. Consider removing that.
I think the
reload_api_settings
logic adds unnecessary scope to the goal of this pull request. Consider removing that.
Done!
Fix
dj-rest-auth
Messy SettingsThis PR is created to make all
dj-rest-auth
settings stored in one dict variable calledREST_AUTH
. Also this PR related to Operation Clean Config Project. Please read the configuration docs here https://dj-rest-auth.readthedocs.io/en/latest/configuration.htmlSummary
Before this PR
After this PR
What is changed?
dj-rest-auth
Documentationsettings.py
REST
orREST_AUTH
is shorted by removing those prefix@override_api_settings(JWT_AUTH_HTTPONLY=False)
totests.test_api.APIBasicTests.test_blacklisting
since the default isTrue
based on documentation, even though i found the default isFalse
at this line, The value goes against the documentation.@override_api_settings(JWT_AUTH_HTTPONLY=False)
totests.test_api.APIBasicTests.test_rotate_token_refresh_view
. And add@override_api_settings(SESSION_LOGIN=False)
totests.test_social.TestSocialConnectAuth.test_social_connect
,tests.test_api.APIBasicTests.test_registration_allowed_with_custom_no_password_serializer
, andfix tests.test_api.APIBasicTests.test_registration
. I'm confused with this line, it looks like the default value ofREST_SESSION_LOGIN
or in new settings calledSESSION_LOGIN
isFalse
. Once again the value goes against the documentation.How to Fix?
rest_framework
too.Difficulty, NEED Help!!!
From my current commit in PR, I'm stuck with
app_settings.py
with these lineThe problem is
setting
value never changed to'REST_AUTH'
, instead'REST_FRAMEWORK'
. How to fix this?Make a better
override_api_settings
intests.utils
Fix the documentation