search

iMerica / dj-rest-auth

Authentication for Django Rest Framework
https://dj-rest-auth.readthedocs.io/en/latest/index.html
MIT License
1.63k stars 304 forks source link

added option to set JWT_AUTH_COOKIE_DOMAIN. #526

Closed jeff-zimmerman closed 1 year ago

jeff-zimmerman commented 1 year ago

SimpleJWT and vanilla Django both have this option, so I thought it would be a good thing to add.

iMerica commented 1 year ago

I would prefer to make set_cookie use SESSION_COOKIE_DOMAIN if it exists. This way we don't need to support yet another configuration parameter.

jeff-zimmerman commented 1 year ago

There are two similar options in vanilla Django CSRF_COOKIE_DOMAIN and SESSION_COOKIE_DOMAIN. Dj rest auth has configs for both card and sessions, so I just want to double check to see which you'd prefer.

On Mon, Jul 3, 2023, 2:34 PM Michael @.***> wrote:

I would prefer to make set_cookie use SESSION_COOKIE_DOMAIN if it exists. This way we don't need to support yet another configuration parameter.

— Reply to this email directly, view it on GitHub https://github.com/iMerica/dj-rest-auth/pull/526#issuecomment-1618987601, or unsubscribe https://github.com/notifications/unsubscribe-auth/APXZZKXQJNAWIGK7AR5VKQDXOMGD5ANCNFSM6AAAAAAZZ7GP54 . You are receiving this because you authored the thread.Message ID: @.***>