iMerica / dj-rest-auth

Authentication for Django Rest Framework
https://dj-rest-auth.readthedocs.io/en/latest/index.html
MIT License
1.62k stars 302 forks source link

chore(test): bump `django-allauth` to 0.62.1 #627

Open gekoke opened 2 months ago

gekoke commented 2 months ago

Bumps tests to support django-allauth 0.62.1.

Also fixes some incidental test breakages that came with the version bump.

Fixes #626.

pennersr commented 2 months ago

@gekoke Can you also integrate the changes listed here? https://github.com/iMerica/dj-rest-auth/commit/0a2023624cc46e043f2936fcf18882d8b1ae885b -- particularly the get_scope() poses any issue.

gekoke commented 2 months ago

Done in 3342e05.

Where our changes diverge, I went with yours - that is:

modified   dj_rest_auth/tests/test_serializers.py
@@ -120,10 +120,7 @@ class TestSocialLoginSerializer(TestCase):
     def setUpTestData(cls):
         cls.request_data = {"access_token": "token1234"}
         cls.request = APIRequestFactory().post(cls.request_data, format='json')
-
-        middleware = SessionMiddleware(get_response=MagicMock())
-        middleware(cls.request)
-
+        cls.request.session = {}
         social_app = SocialApp.objects.create(
             provider='facebook',
             name='Facebook',
@@ -153,7 +150,7 @@ class TestSocialLoginSerializer(TestCase):
         serializer.is_valid()
         self.assertDictEqual(serializer.errors, self.NO_ADAPTER_CLASS_PRESENT)

-    @patch('allauth.socialaccount.providers.facebook.views.FacebookOAuth2Adapter.complete_login')
+    @patch('allauth.socialaccount.providers.facebook.flows.complete_login')
     @patch('allauth.socialaccount.adapter.DefaultSocialAccountAdapter.pre_social_login')
     def test_immediate_http_response_error(self, mock_pre_social_login, mock_fb_complete_login):
         dummy_view = SocialLoginView()

All tests pass on 3342e05.

pennersr commented 2 months ago

@gekoke We also need this change: https://github.com/pennersr/dj-rest-auth/commit/4f6ca7664bb22c44d95a8c91714f1802d5c2a184 -- for the upcoming new allauth headless functionality several internals to which dj-rest-auth hooks up are changed.

gekoke commented 2 months ago

@pennersr Done in 7eb2ec9

Olfredos6 commented 1 week ago

Anything we can do to help expedite this PR?

evans23 commented 1 week ago

Anything we can do to help expedite this PR?

willing to help as well.