search

iMi-digital / magento2-friendly-captcha

Magento 2 Module to add the Friendly Captcha service to certain forms.
Other
16 stars 13 forks source link

Update Config.php #39

Closed RanaMuhammadIrshad closed 8 months ago

amenk commented 8 months ago

@RanaMuhammadIrshad good catch I think @DanieliMi MR makes sense, correct?

sprankhub commented 8 months ago

While we are at it... Wouldn't this also need to be updated?

https://github.com/iMi-digital/magento2-friendly-captcha/blob/97aa259765c9c24a8402e258b08cd63a4ad7457e/Model/Config.php#L139

I guess this needs to be https://api.friendlycaptcha.com/api/v1/puzzle.

amenk commented 8 months ago

While we are at it... Wouldn't this also need to be updated?

https://github.com/iMi-digital/magento2-friendly-captcha/blob/97aa259765c9c24a8402e258b08cd63a4ad7457e/Model/Config.php#L139

I guess this needs to be https://api.friendlycaptcha.com/api/v1/puzzle.

I think the standard is hard coded in the JS, if it is not supplied, that URL is used - but we could as well specify it

sprankhub commented 8 months ago

Okay. @amenk @DanieliMi, could we merge this very soon? Currently, the EU endpoint is broken with this module due to this bug.

amenk commented 8 months ago

@RanaMuhammadIrshad thank you for your contribution. @sprankhub Thank you for the reminder. Merged & Released.