iMicknl / ha-tahoma

Custom component for Home Assistant to interact with smart devices via Somfy TaHoma or other OverKiz based API's.
MIT License
152 stars 30 forks source link

Regression in 2.6.0 for "AtlanticPassAPCHeatingAndCoolingZone" device #517

Closed gerardsamara closed 3 years ago

gerardsamara commented 3 years ago

Did you read the instructions?

The problem

Hello ,

Following the update to 2.6.0 , the following errors are displayed in the log

2021-08-10 18:47:47 ERROR (MainThread) [homeassistant.components.climate] Error adding entities for domain climate with platform tahoma Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 382, in async_add_entities await asyncio.gather(*tasks) File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 587, in _async_add_entity await entity.add_to_platform_finish() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 710, in add_to_platform_finish await self.async_added_to_hass() File "/config/custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_and_cooling_zone.py", line 76, in async_added_to_hass base_url = self.get_base_device_url() AttributeError: 'AtlanticPassAPCHeatingAndCoolingZone' object has no attribute 'get_base_device_url' 2021-08-10 18:47:47 ERROR (MainThread) [homeassistant.components.climate] Error while setting up tahoma platform for climate Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 257, in _async_setup_platform await asyncio.gather(*pending) File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 382, in async_add_entities await asyncio.gather(*tasks) File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 587, in _async_add_entity await entity.add_to_platform_finish() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 710, in add_to_platform_finish await self.async_added_to_hass() File "/config/custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_and_cooling_zone.py", line 76, in async_added_to_hass base_url = self.get_base_device_url() AttributeError: 'AtlanticPassAPCHeatingAndCoolingZone' object has no attribute 'get_base_device_url'

Capture zone1 developer tools Capture tahoma zone1 lovelace

The temperature now is missing for this device in Lovelace

Please can you have a look ? Thank you

What version of this integration (ha-tahoma) has the issue?

2.6.0

What version of Home Assistant Core has the issue?

2021.8.4

Which gateway / hub do you use?

Cozytouch

Device model

R002412300 by Atlantic Group

Device type

Firmware: io:AtlanticPassAPCHeatPumpMainComponent

Additional information

No response

Relevant log output

2021-08-10 18:47:47 ERROR (MainThread) [homeassistant.components.climate] Error adding entities for domain climate with platform tahoma
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 382, in async_add_entities
await asyncio.gather(*tasks)
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 587, in _async_add_entity
await entity.add_to_platform_finish()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 710, in add_to_platform_finish
await self.async_added_to_hass()
File "/config/custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_and_cooling_zone.py", line 76, in async_added_to_hass
base_url = self.get_base_device_url()
AttributeError: 'AtlanticPassAPCHeatingAndCoolingZone' object has no attribute 'get_base_device_url'
2021-08-10 18:47:47 ERROR (MainThread) [homeassistant.components.climate] Error while setting up tahoma platform for climate
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 257, in _async_setup_platform
await asyncio.gather(*pending)
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 382, in async_add_entities
await asyncio.gather(*tasks)
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 587, in _async_add_entity
await entity.add_to_platform_finish()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 710, in add_to_platform_finish
await self.async_added_to_hass()
File "/config/custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_and_cooling_zone.py", line 76, in async_added_to_hass
base_url = self.get_base_device_url()
AttributeError: 'AtlanticPassAPCHeatingAndCoolingZone' object has no attribute 'get_base_device_url'
gerardsamara commented 3 years ago

Hi ,

I did not see at first that the entities have been duplicated as per this screenshot

Capture ha tahoma

tetienne commented 3 years ago

Hi thx for reporting this.

It will been fixed with https://github.com/iMicknl/ha-tahoma/pull/516

iMicknl commented 3 years ago

Please update to 2.6.1, which should contain this fix. Thanks!

gerardsamara commented 3 years ago

I have updated to 2.6.1 and the errors are gone Thank you for the fix

Do I need to delete and re-install the ha-tahoma custom component+integration as I have duplicated devices as per the enclosed screenshot ( to have a cleaner configuration) ?

Capture ha tahoma

tetienne commented 3 years ago

@gerardsamara Yes you can reinstall the component, we have perform a small fix about the generated entity ids.

gerardsamara commented 3 years ago

Done. Everything ok Thank you

⁣Télécharger BlueMail pour Android ​

Le 11 août 2021 à 15:04, à 15:04, Thibaut @.> a écrit: @. Yes you can reinstall the component, we have perform a

small fix about the generated entity ids.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/iMicknl/ha-tahoma/issues/517#issuecomment-896809139