search

iMoonDay / Soulbound

MIT License
0 stars 3 forks source link

Fix mixin errors #2

Closed Kneelawk closed 1 year ago

Kneelawk commented 1 year ago

This PR

This PR fixes the mixin errors with the BackpackUtilsMixin. The mixin seems to be working correctly when I tested in a production MultiMC instance. However, something seems to be preventing the backpack from being put back on the player. Instead the backpack currently just appears back in the player's inventory upon respawning.

iMoonDay commented 1 year ago

I seem to have fixed it. You can check out the new code. But I find that placing the backpack on the ground and picking it up again does not restore the enchantment. I need to try and fix it again.

Kneelawk commented 1 year ago

I'm pretty sure the enchantments falling off the backpack when it's placed is a problem with Traveler's Backpack because that happens for the other soulbound enchantments too.

iMoonDay commented 1 year ago

I have an idea: If there is soulbound enchantment, add a nbt to the block entity when placing it, and automatically enchant the dropped item stack when digging out or picking it up.