iMoonDay / Soulbound

MIT License
0 stars 3 forks source link

Not compatible with Universal Graves mod. #9

Closed pil0lo closed 4 months ago

pil0lo commented 4 months ago

https://www.curseforge.com/minecraft/mc-mods/universal-graves

The Universal Graves mode is a mode that creates a gravestone when you die. Soulbound enchanted items are also included when a tombstone is created in Universal Graves mode... Can't it stay in inventory?

iMoonDay commented 4 months ago

Open the Universal Graves mod's config file, find the _blocked_enchantments_ in there, and add soulbound:soulbound to it.

pil0lo commented 4 months ago

The blocks_enchantments file is not visible. Which file exactly do I need to find?

1

{ "type": "minecraft:block", "pools": [ { "bonus_rolls": 0.0, "conditions": [ { "condition": "minecraft:survives_explosion" } ], "entries": [ { "type": "minecraft:item", "name": "universal_graves:visual_grave" } ], "rolls": 1.0 } ] }

iMoonDay commented 4 months ago

./config/universal-graves/config.json

pil0lo commented 4 months ago

C:\Users\user\AppData\Roaming.minecraft\config\universal-graves

Can't find it in the list..... [blocks_enchantments] 1

{ "_comment": "Before changing anything, see https://github.com/Patbox/UniversalGraves#configuration", "config_version": 4, "protection": { "non_owner_protection_time": 900, "self_destruction_time": 1800, "drop_items_on_expiration": true, "attackers_bypass_protection": false, "use_real_time": false }, "interactions": { "unlocking_cost": { "type": "free", "count": 0 }, "give_death_compass": true, "enable_use_death_compass_to_open_gui": true, "enable_click_to_open_gui": true, "shift_and_use_quick_pickup": true, "allow_remote_protection_removal": true, "allow_remote_breaking": true, "allow_remote_unlocking": false }, "storage": { "experience_type": "percent_points", "experience_percent:setting_value": 100.0, "can_store_only_xp": false, "alternative_experience_entity": false, "blocked_enchantments": [] }, "placement": { "player_grave_limit": -1, "replace_any_block": false, "max_distance_from_source_location": 8, "shift_location_on_failure": true, "max_shift_tries": 5, "max_shift_distance": 40, "generate_on_top_of_fluids": false, "generate_on_ground": false, "create_gravestone_after_emptying": false, "restore_replaced_block_after_player_breaking": true, "cancel_creation_for_damage_types": {}, "cancel_creation_for_ignored_attacker_types": {}, "blocking_predicates": [], "block_in_protected_area": {}, "blacklisted_worlds": [], "blacklisted_areas": {}, "creation_default_failure_text": "<lang:'text.graves.creation_failed':'${position}':'${world}'>", "creation_claim_failure_text": "<lang:'text.graves.creation_failed_claim':'${position}':'${world}'>" }, "teleportation": { "cost": { "type": "creative", "count": 1 }, "required_time": 5, "y_offset": 1.0, "invincibility_time": 2, "allow_movement_while_waiting": false, "text": { "timer": "<lang:'text.graves.teleport.teleport_timer':'${time}'>", "timer_allow_moving": "<lang:'text.graves.teleport.teleport_timer_moving':'${time}'>", "location": "<lang:'text.graves.teleport.teleport_location':'${position}'>", "canceled": "<lang:'text.graves.teleport.teleport_cancelled'>" } }, "model": { "default": "default", "alternative": [], "hide_f3_debug_lines": true, "gravestone_item_base": "minecraft:skeleton_skull" }, "ui": { "title": "<lang:'text.graves.players_grave':'${player}'>", "admin_title": "<lang:'text.graves.admin_graves'>", "list_grave_icon": { "base": { "icon": "minecraft:chest", "text": [ "${position} (${world})", "${death_cause}", "<lang:'text.graves.items_xp':'${item_count}':'${xp}'>", "<lang:'text.graves.protected_time':'${protection_time}'>", "<lang:'text.graves.break_time':'${break_time}'>" ] }, "alt": { "icon": "minecraft:trapped_chest", "text": [ "${position} (${world})", "${death_cause}", "<lang:'text.graves.items_xp':'${item_count}':'${xp}'>", "<lang:'text.graves.not_protected'>", "<lang:'text.graves.break_time':'${break_time}'>" ] } }, "admin_list_grave_icon": { "base": { "icon": "minecraft:chest", "text": [ "[${player}</>]</> ${position} (${world})", "${death_cause}", "<lang:'text.graves.items_xp':'${item_count}':'${xp}'>", "<lang:'text.graves.protected_time':'${protection_time}'>", "<lang:'text.graves.break_time':'${break_time}'>" ] }, "alt": { "icon": "minecraft:trapped_chest", "text": [ "[${player}</>]</> ${position} (${world})", "${death_cause}", "<lang:'text.graves.items_xp':'${item_count}':'${xp}'>", "<lang:'text.graves.not_protected'>", "<lang:'text.graves.break_time':'${break_time}'>" ] } }, "grave_info": { "base": { "icon": "minecraft:oak_sign", "text": [ "${position} (${world})", "${death_cause}", "<lang:'text.graves.items_xp':'${item_count}':'${xp}'>", "<lang:'text.graves.protected_time':'${protection_time}'>", "<lang:'text.graves.break_time':'${break_time}'>" ] }, "alt": { "icon": "minecraft:oak_sign", "text": [ "${position} (${world})", "${death_cause}", "<lang:'text.graves.items_xp':'${item_count}':'${xp}'>", "<lang:'text.graves.not_protected'>", "<lang:'text.graves.break_time':'${break_time}'>" ] } }, "unlock_grave": { "base": { "icon": "minecraft:gold_ingot", "text": [ "<#ffd257><lang:'text.graves.gui.unlock_grave'>", "<lang:'text.graves.gui.cost'> <#cfcfcf>${cost}" ] }, "alt": { "icon": "minecraft:gold_ingot", "text": [ "<lang:'text.graves.gui.unlock_grave'>", "<lang:'text.graves.gui.cost'> <#cfcfcf>${cost} (<lang:'text.graves.gui.cost.not_enough'>)" ] } }, "previous_button": { "base": { "icon": { "id": "universal_graves:icon", "count": 1, "components": { "universal_graves:texture": "previous_page" } }, "text": "<lang:'text.graves.gui.previous_page'>" }, "alt": { "icon": { "id": "universal_graves:icon", "count": 1, "components": { "universal_graves:texture": "previous_page_blocked" } }, "text": "<lang:'text.graves.gui.previous_page'>" } }, "next_button": { "base": { "icon": { "id": "universal_graves:icon", "count": 1, "components": { "universal_graves:texture": "next_page" } }, "text": "<lang:'text.graves.gui.next_page'>" }, "alt": { "icon": { "id": "universal_graves:icon", "count": 1, "components": { "universal_graves:texture": "next_page_blocked" } }, "text": "<lang:'text.graves.gui.next_page'>" } }, "remove_protection_button": { "base": { "icon": { "id": "universal_graves:icon", "count": 1, "components": { "universal_graves:texture": "remove_protection" } }, "text": "<lang:'text.graves.gui.remove_protection'>" }, "alt": { "icon": { "id": "universal_graves:icon", "count": 1, "components": { "universal_graves:texture": "remove_protection" } }, "text": [ "<lang:'text.graves.gui.remove_protection'>", "<lang:'text.graves.gui.cant_reverse'>", "", "<lang:'text.graves.gui.click_to_confirm'>" ] } }, "break_grave_button": { "base": { "icon": { "id": "universal_graves:icon", "count": 1, "components": { "universal_graves:texture": "break_grave" } }, "text": "<lang:'text.graves.gui.break_grave'>" }, "alt": { "icon": { "id": "universal_graves:icon", "count": 1, "components": { "universal_graves:texture": "break_grave" } }, "text": [ "<lang:'text.graves.gui.break_grave'>", "<lang:'text.graves.gui.cant_reverse'>", "", "<lang:'text.graves.gui.click_to_confirm'>" ] } }, "quick_pickup_button": { "icon": { "id": "universal_graves:icon", "count": 1, "components": { "universal_graves:texture": "quick_pickup" } }, "text": "<lang:'text.graves.gui.quick_pickup'>" }, "fetch_button": { "base": { "icon": "minecraft:lead", "text": "<lang:'text.graves.gui.fetch'>" }, "alt": { "icon": "minecraft:lead", "text": "<lang:'text.graves.gui.fetch'>" } }, "teleport_button": { "base": { "icon": "minecraft:ender_pearl", "text": [ "<#a52dfa><lang:'text.graves.gui.teleport'>", "<lang:'text.graves.gui.cost'> <#cfcfcf>${cost}" ] }, "alt": { "icon": "minecraft:ender_pearl", "text": [ "<lang:'text.graves.gui.teleport'>", "<lang:'text.graves.gui.cost'> <#cfcfcf>${cost} (<lang:'text.graves.gui.cost.not_enough'>)" ] } }, "back_button": { "icon": "minecraft:structure_void", "text": "<lang:'text.graves.gui.quick_pickup'>" }, "bar": { "icon": "minecraft:white_stained_glass_pane", "text": "" } }, "text": { "grave_created": "<lang:'text.graves.created_at_expire':'${position}':'${world}':'${break_time}'>", "protection_ended": "<lang:'text.graves.no_longer_protected':'${position}':'${world}':'${item_count}'>", "grave_expired": "<lang:'text.graves.expired':'${position}':'${world}':'${item_count}'>", "grave_broken": "<lang:'text.graves.somebody_broke':'${position}':'${world}':'${item_count}'>", "grave_access_payment_no_access": "<lang:'text.graves.grave_unlock_payment.no_access'>", "grave_payment_accepted": "<lang:'text.graves.grave_unlock_payment.accepted'>", "grave_payment_failed": "<lang:'text.graves.grave_unlock_payment.failed':'${cost}'>", "years_suffix": "y", "days_suffix": "d", "hours_suffix": "h", "minutes_suffix": "m", "seconds_suffix": "s", "infinity": "∞", "date_format": "dd.MM.yyyy, HH:mm", "world_names": {} } }

iMoonDay commented 4 months ago

There should be some differences from version to version, I saw your screenshot, it's the _blockedenchantments located under storage

pil0lo commented 4 months ago

[blocked_enchants]List found. You just have to write [soulbound:soulbound] in [] in this list, right? thank you I'll go outside for a while and check when I get home. thank you!!!

iMoonDay commented 4 months ago

Yes, but it needs to be in quotes, it should be [“soulbound:soulbound”]

pil0lo commented 4 months ago

The enchantments marked in squares are the same enchantments. I wrote it down as you said, but it failed. I wrote it in Korean and also in English.

1 2 3

iMoonDay commented 4 months ago

Are you sure this soulbound enchantment is from my mod? I remember my mod wasn't translated into Korean

iMoonDay commented 4 months ago

I seem to have found the problem, I misspelled the quotes before and the mod didn't recognize them correctly, change them to ["soulbound:soulbound"]

pil0lo commented 4 months ago

When I added various enchantment modes, there were so many that I changed the names to Korean to categorize them.

"storage": { "experience_type": "percent_points", "experience_percent:setting_value": 100.0, "can_store_only_xp": false, "alternative_experience_entity": false, "blocked_enchantments": ["soulbound:soulbound"]

If you still die, all your items will be lost. If you can't make items disappear, I think you'll have to remove the "Universal Graves" mod.

ko_kr.json

iMoonDay commented 4 months ago

I'm kind of missing your point. Is it still not in effect?

pil0lo commented 4 months ago

When you die, all items are still lost.

iMoonDay commented 4 months ago

Won't it now be put into a tombstone, but dropped normally?

pil0lo commented 4 months ago

I uploaded it as a YouTube video. If you look at your inventory, it disappears when you die.

https://youtu.be/pIwDOSMY6lE

iMoonDay commented 4 months ago

I just tested it and realized it's a bug specific to version 1.21, wait for me to fix it.

iMoonDay commented 4 months ago

Unfortunately, I tried to fix it, and in the end it turned out to be a problem with the Universal Graves mod, to whom I've filed an ISSUE.

iMoonDay commented 4 months ago

Universal Graves mod has been updated, you can try it to see if it's fixed.

pil0lo commented 4 months ago

It works fine. It's solved. Thank you.