search

iMoonDay / TradeEnchantmentDisplay

Automatically display the enchantment name of traded items
https://modrinth.com/mod/trade-enchantment-display
MIT License
0 stars 0 forks source link

[1.19.2] Incompatible with CC:Tweaked #4

Open TheROFL98 opened 4 days ago

TheROFL98 commented 4 days ago

When interacting with a ComputerCraft Turtle (haven't tested regular computers but I imagine it will yield the same result) crashes my game.

Forge 43.4.4 CC:Tweaked 1.101.4 Trade Enchantment Display 1.1.3

crash.txt

TheROFL98 commented 4 days ago

The bug doesn't seem to be reproducible with the latest version of the mods involved in 1.20.1, however downgrading CC:Tweaked to 1.105.1 seems to trigger the bug. Currently investigating further

iMoonDay commented 4 days ago

My mod tries to determine whether it is tradeable by accessing the block's menu, but ComputerCraft Turtle does not allow menus to be called on the client side, so it throws an exception

TheROFL98 commented 4 days ago

I've determined that CC:Tweaked may have inadvertently fixed the issue with version 1.110.0, as testing that version against your mod doesn't seem to reproduce the bug.

iMoonDay commented 4 days ago

So do I need to make a fix for version 1.19.2?

TheROFL98 commented 4 days ago

If that's possible, yes.

iMoonDay commented 4 days ago

It's easy, but it takes a while to upload

TheROFL98 commented 4 days ago

That's completely fine! I can wait :)