search

iNKORE-NET / UI.WPF.Modern

Modern (Fluent 2) styles and controls for your WPF applications
GNU Lesser General Public License v2.1
447 stars 39 forks source link

Temporary Fix #29

Closed ghost1372 closed 10 months ago

ghost1372 commented 10 months ago

temporary fix

NotYoojun commented 10 months ago

So you just use the CombinedResource as a merged dictionary in the other dictionaries. I don't think this is a good solution cause it will make the CombinedResources loaded multiple times.

ghost1372 commented 10 months ago

So you just use the CombinedResource as a merged dictionary in the other dictionaries. I don't think this is a good solution cause it will make the CombinedResources loaded multiple times.

Yes this is not a good idea, i wonder why referencing single style not working.

With this condition, you have 2 ways, either ignore this feature and revert the commits. Or merge both libraries into one library. I try to implement the second way to see its effects.

I am sorry for what happened

NotYoojun commented 10 months ago

What about applying XAMLTools to the iNKORE.UI.WPF.Modern.Controls library?

ghost1372 commented 10 months ago

What about applying XAMLTools to the iNKORE.UI.WPF.Modern.Controls library?

It should work, I will test as soon as I get home

ghost1372 commented 10 months ago

What about applying XAMLTools to the iNKORE.UI.WPF.Modern.Controls library?

You mean we use XamlTools only for iNKORE.UI.WPF.Modern.Controls and not iNKORE.UI.WPF.Modern ?? Or you mean XamlTools for both? Because i tested for both and not worked.

NotYoojun commented 10 months ago

I mean for both. If that still happens, I guess I have to revert those changes 😭😭

ghost1372 commented 10 months ago

I mean for both. If that still happens, I guess I have to revert those changes 😭😭

Yes unfortunately