Added server adding page

iNPUTmice / ServerStatus

Status page and uptime monitor for XMPP servers

https://status.conversations.im

BSD 3-Clause "New" or "Revised" License

24 stars 8 forks source link

Added server adding page #4

Closed RishiRaj22 closed 6 years ago

RishiRaj22 commented 6 years ago

Users can add their credentials from the frontend by going to /add or by clicking the link in the footer. The credentials are verified and added to the database and the tests are rescheduled accordingly.

In config.json, instead of having an array of credentials, the user has to populate the credentials in the database from the UI. A new attribute primaryDomain has been added to the configuration.

iNPUTmice commented 6 years ago

Hi,

I added a bunch of review comments that I would consider a must before I can merge this.

Then there is another thing that would be nice to have - but only if you have the time: It might take some time for the service to check the credentials; maybe we can add some dynamic spinning wheel thing; Especially since the Compliance Tester webservice will make use of dynamic elements like that it might be good to see how you approach that.

RishiRaj22 commented 6 years ago

Thanks for the feedback. I will implement those suggestions right away. As for the spinning wheel, I intended to work on it after getting your feedback on this.

RishiRaj22 commented 6 years ago

I have added the changes. I will work on the loading screen(while the test runs) tomorrow.

RishiRaj22 commented 6 years ago

I have added the loading screen.

iNPUTmice commented 6 years ago

Hi,

I'm finally ready to actually merge this. I have two more small comments that don’t actually have to do anything with the code but are just a matter of personal taste.

Can we change the color green to the color blue (same color as the one used in links) in the add dialog. I think this will fit in better with the rest of the page.

And can we actually not link to the 'add' page from the footer. I'd like to keep the 'add' page a 'secret' for now. I don’t want every random server on there. I'd rather just give the deep link to the add page to certain individuals.

RishiRaj22 commented 6 years ago

I made the required changes

iNPUTmice commented 6 years ago

Two more minor nitpicks. (I promise this will be over soon.)

Logically I think the verifyCredentials should not be called from the CredentialsStore but from the controller. (Keep store logic seperate from other things.)
After doing the step above we can actually distinguish between a failure to write to DB and a auth failure. Both should have individual error messages.
The add controller needs to check if credentials for the server already exists and display an error message like Credentials for this server already exists. Click here to view results or something.

RishiRaj22 commented 6 years ago

Done