iNZightVIT / Lite

Shiny Application for iNZight.
http://lite.docker.stat.auckland.ac.nz/
GNU General Public License v3.0
4 stars 6 forks source link

update survery obj in summary #378

Open chrk623 opened 1 week ago

chrk623 commented 1 week ago

374

railway-app[bot] commented 1 week ago
🚅 Deployed to the Lite-pr-378 environment in inzight-lite Service Status Web Updated (UTC)
Lite ✅ Success (View Logs) Web Sep 7, 2024 at 10:46 pm
chrk623 commented 1 week ago

TODO: check other visualize tabs, i.e., plot, inference ...etc

tmelliott commented 1 week ago

I'm not sure if this will solve the issue generally - it's only going to work for inference?

What needs to happen is that, inside the survey design server, the survey design object needs to react to values$data, i.e., setDesign() needs to be called whenever the data changes, so maybe after Line 103, there could be an added reactive value alongside input$create.design??

  1. Is that even possible with the current set-up?
  2. If not, is there a more global fix (i.e., updating the design when the data is changed, not when a component uses it)?
chrk623 commented 1 week ago

Thought about 1. but I had some doubts, 2. should work though. Let me give it a go.

chrk623 commented 1 week ago

Still more TODOs: Currently only works for summary and inference.

https://github.com/iNZightVIT/Lite/blob/e2f156349a569d409461de40f736d6654b7be468/panels/C1_Visualize/2_visualize-panel-server.R#L7893

Looks OK, dataset in get.data.set() and vis.par() is updated when the dataset changes i.e., filtered, but the plot is not updating. Figure out why..? Is this the line that plots the data?