search

iNZightVIT / iNZightTS

The time series functionality designed for use within iNZight.
https://timeseries.inzight.nz/
1 stars 1 forks source link

seasonplot: Multiplicative #12

Closed wesleyburr closed 4 years ago

wesleyburr commented 6 years ago

If you attempt to use multiplicative seasonality on a series with negatives (e.g., monthly temperature), the error message that comes back from seasonplot is highly uniformative. There's no logical checks in decomposition to make sure that the series is suitable for multiplicative, so the logarithm gives NaN's, and stl dies.

Suggest: some logical checks at the start of decomposition() to give informative error messages.

If I have time, I'll submit a pull request in a couple of weeks that fixes this issue.

tmelliott commented 6 years ago

Thanks @wesleyburr - we've been aware of this for some time, so if you find the time to submit a PR that'd be awesome!