search

iNavFlight / OpenTX-Telemetry-Widget

INAV Lua Telemetry with support for EdgeTX
https://luatelemetry.readthedocs.io/en/latest/
GNU General Public License v3.0
156 stars 32 forks source link

2.2.1 breaks Crossfire Compatibility on X9D+ Radios #113

Closed b14ckyy closed 1 year ago

b14ckyy commented 1 year ago

Describe the bug

With the Version 2.2.1 on the X9D+ Radio and Crossfire the Widget shows lost telemetry alarm constantl. It still Updates certain values like Battery Voltage, Current Draw, Sat count and maybe some more but not the Attitude, GPS coordinates and constant Telemetry Lost Warning. Works fine on TX16S with Crossfire. Downgrading to 2.2.0 solves the issue.

To reproduce

  1. Install 2.2.1 on a X9D+ or similar
  2. Bind a Crossfire INAV Craft and discover sensors
  3. Restart Radio to refresh the LUA Sensor detection
  4. Check LUA status

Expected behavior

LUA Should work normal also with Crossfire

Screenshots

image

Radio and model settings

opentx-x9d+-eu-lua-noheli-noras-en.zip LUA.zip Dart XL (Model Number 4) is the one used here.

Additional context

N/A

stronnag commented 1 year ago

Please provide a log fiile ..... (or a X9D+ Radio)

stronnag commented 1 year ago

Please also provide details of the radio firmware ....

b14ckyy commented 1 year ago

Please also provide details of the radio firmware ....

added LUA, OTX data and Firmware with EEPROM Dump.

stronnag commented 1 year ago

Thanks, look forward to seeing the OTX (csv) log.

b14ckyy commented 1 year ago

Oh sorry misunderstood you. Here you go. iNAV-Wing-2023-08-13.zip

stronnag commented 1 year ago

Thanks, that looks horribly sane at first glance.

stronnag commented 1 year ago

There were some contributed changes to how CRSF "telemetry" recognition works e.g https://github.com/iNavFlight/OpenTX-Telemetry-Widget/pull/78 (mainly for ELRS diversity). I would not be surprised if these were not tested on OTX and perhaps broke CRSF on OTX (vice ETX).

Can you please try the attached, which reinstates the old test (as well as incorporating the later test). LuaTelemetry_v2.2.1-113.zip

b14ckyy commented 1 year ago

Yep, that one works.

stronnag commented 1 year ago

It works with ELRS on EdgeTX as well, so we'll go with it.

b14ckyy commented 1 year ago

But its interesting that this only seemed to be a problem on the X9D. Worked with no problem on 2.2.1 on the TX16S.

stronnag commented 1 year ago

Merged to master, closing.

stronnag commented 1 year ago

But its interesting that this only seemed to be a problem on the X9D. Worked with no problem on 2.2.1 on the TX16S.

Indeed, with the diversity between Edge and Open TX, numerous new RX and mickey-mouse toy TX with insufficient, ill defined buttons, this project is rapidly becoming an unmaintainable train wreck.

b14ckyy commented 1 year ago

Oh good point. I have EdgeTX on mine maybe that's why it worked there.

stronnag commented 1 year ago

Oh good point. I have EdgeTX on mine maybe that's why it worked there.

I expect that is indeed the case ... train wreck