search

iNavFlight / OpenTX-Telemetry-Widget

INAV Lua Telemetry with support for EdgeTX
https://luatelemetry.readthedocs.io/en/latest/
GNU General Public License v3.0
156 stars 32 forks source link

revert old CRSF tests (#113) #114

Closed stronnag closed 1 year ago

stronnag commented 1 year ago

Combines old CRSF test with newer test from #78 (which broke CRSF/OpenTX)

stronnag commented 1 year ago

@rmaia3d could you please test that current master still behaves correctly for your diversity RX ?

rmaia3d commented 1 year ago

Ok, I will test it as soon as possible and report the results!

rmaia3d commented 1 year ago

Sorry for the delay, but finally had some time to test. The telemetry detection works just fine with my diversity Rx's using the lua in master branch.

However, the RFMD detection seems broken. It doesn't detect the packet rate, showing only "50Hz", regardless of what's actually being used.

I did some investigation and it looks like the data.elrs parameter is not being updated accordingly (it is not detecting the ELRS major version). It's value remains as either 0 or -1. I couldn't find the reason for that, as I couldn't locate where the initial ELRS detection calls are made, but I suspect something is broken there.

Previous version of the scripts I was running (from late Feb/2023) was running just fine (and still is). So, some change in master since then probably broke this.

stronnag commented 1 year ago

Thanks. I now have an ELRS RX, so I can check this.

stronnag commented 1 year ago

2.2.2 is working OK here. Displays the correct packet rate as set via the ELRS widget (ELRS 3)

rmaia3d commented 12 months ago

If it is working for you, it probably was a mess up on my part. I will try testing again as soon as possible.