Only support otx log sematics

iNavFlight / OpenTX-Telemetry-Widget

INAV Lua Telemetry with support for EdgeTX

https://luatelemetry.readthedocs.io/en/latest/

GNU General Public License v3.0

156 stars 32 forks source link

Only support otx log sematics #115

Closed stronnag closed 1 year ago

stronnag commented 1 year ago

Regrettably, the EdgeTX changes to log name semantics have proved to be an ongoing problem for the INAV Lua widget's log replay capability; in particular:

The need to use the dir() function to enumerate log files leaves the script open to "CPU limit" forced termination when the user has numerous log files.
The need to use table.sort() to prune the list of log files meant that log replay was not available on small screen / B&W radios.

The replay function has therefore been changed to only support OpenTX file names. Logs may still be replayed on EdgeTX by renaming the required file (MODEL-YYYY-MM-DD_HHMMSS.csv to MODEL-YYYY-MM-DD.csv (i.e. without the time part).

Fixes #101 (again).

rickgode commented 3 months ago

I know many might not find this worthwhile, but I really like it and am glad the functionality can work if we rename the file. I renamed the file and took out the time, but my playback log is still greyed out. Am I missing something? I just updated to EdgeTX 2.10.

Thank you

stronnag commented 3 months ago

Works OK here in ETX 2.10. Note that:

The log finder only looks back 15 days in order to conserve resources.
The log must start with the current model's name.

$ ls LOGS/
'Mr Spaced Out-2023-08-15-165737.csv'  'Mr Spaced Out-2024-05-12.csv'

So for "Mr Spaced Out", there is one valid log on 2024-05-12 (and until 2024-05-27).

stronnag commented 3 months ago

And the LOGS directory is read once, at startup.

rickgode commented 3 months ago

Thank you! It was the 15 days. I thought it was only the naming convention.

rickgode commented 3 months ago

One last question. Now that I have the inav playback working. What step am I missing to run this in companion. Specifically, I was wanting to screen record the inav telemetry script running the log in companion so I could overlay it on my flight footage. When I simulate my radio in companion and scroll over to my inav screen, there is nothing there.

Thanks Again.

stronnag commented 3 months ago

One last question. Now that I have the inav playback working. What step am I missing to run this in companion. Specifically, I was wanting to screen record the inav telemetry script running the log in companion so I could overlay it on my flight footage. When I simulate my radio in companion and scroll over to my inav screen, there is nothing there.

Thanks Again.

No idea, the image I posted was from companion, and here companion plays the log file correctly (& thusly, a few moments on from the first image):

rickgode commented 3 months ago

Thank you again. It helps to read... I needed the LuaTelemetry v2.2.4_lua.zip : Source LUA, compiles on the device, may be required in the simulator. I was using my SD card of my transmitter.

Thanks!