iNavFlight / inav-configurator

GNU General Public License v3.0
565 stars 305 forks source link

Mission Control: Move to centre view confusing - plus some potential enhancements #1311

Open MrD-RC opened 3 years ago

MrD-RC commented 3 years ago

Main problem: move to centre view is confusing

This is my first time messing about with Mission Planner, and with the safehome stuff. I added and saved a safe home. But after moving the map, I wanted to view it again. So, I see a handy little button which says move to centre view. I thought that it would move the view of the map, centred on the safehome. Nope, it moves or adds a safehome to the centre of the current view.

Don't get me wrong. I can see how that would be useful. But the wording is a bit vague, and different actions can be assumed from it. Maybe change the alt text of the target icon to "Put safehome here". That is pretty obvious what it does.

Enhancments

MrD-RC commented 3 years ago

@ArnoTlse you may be the best guy to tag in this :)

ArnoTlse commented 3 years ago

Hi @MrD-RC,

Thanks for the feedback, I will add these 3 points in the todo list. I try to push it in the preparation of the next PR.

Arno

MrD-RC commented 3 years ago

Thanks @ArnoTlse. Great work on this 👍

ArnoTlse commented 2 years ago

Hi,

Here are some news about two of the items mentionned here.

I have updated mission planner with a new button in the SafeHome Tab to center the map view on the selected Safehome point. I have kept the original button and rename the tooltip to indicate that it is to position the SafeHome point selected to the center of the current map view.

I have also modified the mission planner to add the Loiter Radius for Airplane (FW). It will add a yellow circle around the Safehome by retrieving the Loiter Radius from the FC (through MSPHelper).

image

For multirotors and others, the default is to hide this loiter radius. image

I have precised also that the initial Safe Radius is a custom one by changing the legend label.

Arno

MrD-RC commented 2 years ago

That looks awesome @ArnoTlse thank you. The target and eye icons for the safehomes are great. No confusing what they do, even without seeing the tip.