iNavFlight / inav-configurator

GNU General Public License v3.0
565 stars 304 forks source link

[MASTER] Advanced setting, OSD and Mission Control won't load, MSP error #2110

Closed breadoven closed 2 weeks ago

breadoven commented 2 weeks ago

Not possible to load Advanced Settings, OSD and Mission Control tabs with current master connected to INAV current master firmware.

Throws up the following MSP error which I'm pretty sure is nothing to do with anything I've done. Also not sure when it became a problem exactly but must be a fairly recent issue:

Screenshot (261)

breadoven commented 2 weeks ago

It happens every time on the tabs mentioned above for an F722 board configured as a multirotor. However, testing on an F411 board configured as a fixed wing it only happens on the OSD tab, although this is using a slightly out of date version of the current master.

JulioCesarMatias commented 2 weeks ago

I managed to reproduce the problem you described, but when clearing the configurator cache, everything worked normally.

Captura de Tela 2024-06-15 às 11 20 21

breadoven commented 2 weeks ago

Ah well done that fixes it. Is that cache reset button a recent addition ?

Thanks !

Can't help but think this is going to catch people out who won't know to click that button.

mmosca commented 2 weeks ago

Ah well done that fixes it. Is that cache reset button a recent addition ?

Thanks !

Can't help but think this is going to catch people out who won't know to click that button.

Yes. It is Pawel doing some magic to speed up the configurator. Shouldn't be a problem on release code, but changing back an forth between different branches or older snapshots of master can cause issues if you don't reset the cache

stronnag commented 2 weeks ago

It would be neat of the cache included the build id (commit hash) and if the cached build id didn't the current id, then automagically clear the cache. Would save a load of support issues for "nightly" builds.

breadoven commented 2 weeks ago

I added something to flush the cache on disconnect ... but maybe that somewhat defeats its usefulness.

mmosca commented 2 weeks ago

A better approach would probably be to fetch missing item on cache miss.

rts18 commented 2 weeks ago

I attempted to run builds of both masters from yesterday. These are the results. The OSD, Outputs, Failsafe, Tuning, Advanced, MissionControl and GPS tabs hang.

Output tab

And worse. The configuration tab does not load any sensors. I set them to auto and saved. Nothing changed. Capture

The configurator was run on a computer with Windows 10 OS.

However, testing on an F411 board configured as a fixed wing it only happens on the OSD tab.

I have noticed the same. Every FC target I tested worked differently. Some fail to load a few tabs. And others fail to load a dozen tabs. I attempted to clear the cache, with no change here.

Edit: Rebooted the PC and then flushed the cache. Now its good.

DzikuVx commented 2 weeks ago

The issue may appear when setting descriptors changed. In general, once final release is out, there should be no problems as then settings will not change. For now, in case of any problems, flush the cache @breadoven cache flush on disconnect completely breaks the idea @stronnag the idea of build id if probably the best.

breadoven commented 2 weeks ago

I hadn't realised that this is supposed to speed up tab loading even after closing down Configurator. Seemed to work when switching between tabs but then was initially slow to load again on restarting Configurator. Now it loads quickly even after closing and reopening Configurator. The sensor status icons at the top (and runtime calibration indicator I seem to remember) also now work as expected. They were a bit erratic before ... probably because the cache needed flushing perhaps.

So all good with my bodge non-solution now deleted.